refactor: rearrange styles for sharing in app header #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updated select to actually take the size argument into account
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
=======================================
Coverage 85.57% 85.57%
=======================================
Files 758 758
Lines 15525 15525
Branches 1839 1839
=======================================
Hits 13285 13285
Misses 2209 2209
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Jan 26, 2021
| .left-side-content { | ||
| display: flex; | ||
| align-items: center; | ||
| } |
There was a problem hiding this comment.
should we use justify content: flex-start here?
There was a problem hiding this comment.
that's the default, it's already behaving that way.
anandtiwary
reviewed
Jan 26, 2021
projects/components/src/header/application/application-header.component.ts
Show resolved
Hide resolved
anandtiwary
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This rearranged some styles used by components in the app header so they can come from a single source of truth, rather than being redeclared in each component. The select component was also updated to actually respond to its size argument, which was previously ignored.
Testing
Visual verification on top of unit tests.
Checklist: